fix: support ScoreDebug formatting for paths - #376
Draft
umaucher wants to merge 2 commits into
Draft
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Convert filesystem paths to logger-compatible strings while preserving debug formatting. Closes eclipse-score#375
umaucher
force-pushed
the
um_fix-scoredebug-path-formatting
branch
from
August 17, 2026 09:23
e837a4b to
067022d
Compare
umaucher
marked this pull request as ready for review
August 17, 2026 09:40
umaucher
requested review from
PandaeDo,
antonkri and
vinodreddy-g
as code owners
August 17, 2026 09:40
arkjedrz
reviewed
Aug 17, 2026
arkjedrz
left a comment
arkjedrz
left a comment
Contributor
There was a problem hiding this comment.
Why is it required to cast Path and PathBuf to string? .bazelrc for persistency already has build --@score_baselibs//score/log_rust:safety_level=qm, which enables ScoreDebug implementations for those types.
Please also check what's the current state of Path and PathBuf certification. If it's going to be certified then safety_level=qm implementations can be moved into main one in log_rust implementation. If not then persistency should move from using them - replace with strings, with in-repo reimplementation, or even better - a baselibs one.
Once those topics are sorted out I can proceed with a review.
Contributor
Author
|
set to draft until #375 is clarified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathandPathBuflog arguments to logger-compatible owned strings.{:?}debug formatting semantics for paths.ScoreDebugimplementation forJsonBackend.Validation
bazel test --config=per-x86_64-linux --@score_baselibs//score/log_rust:safety_level=asil_b -- //src/rust/rust_kvs:testsbazel build --config=per-x86_64-linux --@score_baselibs//score/log_rust:safety_level=asil_b -- //src/rust/rust_kvs_tool:kvs_toolCloses #375